Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use eea.api.taxonomy because it is deprecated #287

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Nov 4, 2024

We still leave it as dependency to not broke old sites before uninstall (made by an upgrade-step). It need to be removed later.

@mamico mamico marked this pull request as draft November 5, 2024 06:46
@cekk cekk marked this pull request as ready for review November 11, 2024 13:26
@mamico
Copy link
Contributor

mamico commented Nov 20, 2024

@cekk correggimi se sbaglio:
se si lascia eea.api.taxonomies va lasciato collective.taxonomy 3.0.* altrimenti si spacca all'avvio per registrazioni duplicate. finche non si va con taxonomy 3.1, non si può togliere eea.api

La mia proposta è, toglier eea.api, impostare taxonomy 3.1 come versione minima, fare un upgrad step che rimuove il layer di eea.api (non serve che l'egg sia presente, il layer si toglie usando il name del layer)

@cekk
Copy link
Member Author

cekk commented Nov 20, 2024

@cekk correggimi se sbaglio: se si lascia eea.api.taxonomies va lasciato collective.taxonomy 3.0.* altrimenti si spacca all'avvio per registrazioni duplicate. finche non si va con taxonomy 3.1, non si può togliere eea.api

La mia proposta è, toglier eea.api, impostare taxonomy 3.1 come versione minima, fare un upgrad step che rimuove il layer di eea.api (non serve che l'egg sia presente, il layer si toglie usando il name del layer)

corretto

@cekk
Copy link
Member Author

cekk commented Nov 29, 2024

@mamico rimossa completamente la dipendenza

CHANGES.rst Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Dec 3, 2024

Pull Request Test Coverage Report for Build 12136962148

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 69.001%

Totals Coverage Status
Change from base Build 12028800162: 0.06%
Covered Lines: 3321
Relevant Lines: 4813

💛 - Coveralls

@mamico mamico self-requested a review December 4, 2024 09:46
@cekk cekk merged commit 3ff9130 into main Dec 5, 2024
11 checks passed
@cekk cekk deleted the cekk_remove_eea_api_taxonomy branch December 5, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants