Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix change_news_type #255

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix change_news_type #255

merged 3 commits into from
Apr 22, 2024

Conversation

luca-bellenghi
Copy link
Member

dal momento in cui si utilizza collective.taxonomy, i valori vengono indicizzati solo se sono all'interno del vocabolario della tassonomia. in questo caso tipologia_notizia.

Il che significa che change_news_types non presenta tutti i valori possibili perchè non sono a catalogo.
Il che significa che l'unico modo per far funzionare questa vista è prendere i valori delle tipologie dall'oggetto news.
e poi iterare sugli oggetti news per fare la modifica.

@folix-01 chiedo a te giusto perché conosci bene la vista

@luca-bellenghi luca-bellenghi requested a review from folix-01 April 17, 2024 14:10
@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8782299516

Details

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 69.374%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/design/plone/contenttypes/browser/utils/change_news_type.py 6 9 66.67%
Totals Coverage Status
Change from base Build 8782260327: -0.02%
Covered Lines: 3305
Relevant Lines: 4764

💛 - Coveralls

@luca-bellenghi luca-bellenghi merged commit 97dfc93 into main Apr 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants