Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rimosso commit in upgrade-step #239

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Rimosso commit in upgrade-step #239

merged 1 commit into from
Feb 2, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Jan 31, 2024

Fare un commit dentro alla fine di un upgrade-step non serve a niente perché tanto poi viene fatto alla chiusura della request.

Anzi, può potenzialmente portare ad uno stato inconsistente se tra questo e il commit della request c'è un problema/rollback

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7725372464

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.72%

Totals Coverage Status
Change from base Build 7697190174: 0.0%
Covered Lines: 3237
Relevant Lines: 4780

💛 - Coveralls

@eikichi18
Copy link
Member

Perfetto, buonissimo avere la certezza della cosa, grazie

@luca-bellenghi luca-bellenghi merged commit 75e0822 into main Feb 2, 2024
9 checks passed
@cekk cekk deleted the cekk_remove_commit branch July 15, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants