Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency with collective.volto.enhancedlinks #237

Closed
wants to merge 12 commits into from

Conversation

cekk
Copy link
Member

@cekk cekk commented Jan 26, 2024

This is needed for upcoming slate adoption and need for PA to show filesize and mimetype when there is a link to a file or image.

This change only installs a dependency that add a catalog index and metadata, and add some additional infos in serializers.

@coveralls
Copy link

coveralls commented Jan 26, 2024

Pull Request Test Coverage Report for Build 8140882985

Details

  • 11 of 16 (68.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 68.644%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/design/plone/contenttypes/restapi/serializers/dxfields.py 11 12 91.67%
src/design/plone/contenttypes/restapi/serializers/bando.py 0 4 0.0%
Totals Coverage Status
Change from base Build 7971944523: 0.001%
Covered Lines: 3310
Relevant Lines: 4822

💛 - Coveralls

@cekk cekk marked this pull request as draft February 2, 2024 09:57
@cekk cekk marked this pull request as ready for review March 1, 2024 08:59
@cekk cekk requested a review from pnicolli March 1, 2024 08:59
@mamico mamico closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants