feat: video gallery option for caption #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Come hai scritto nel commento per me questa era una feature nuova, andrei a modificare il tag e a scriverlo anche tra le novità del release.log il resto è a posto |
|
@SaraBianchi Fatto |
|
@giuliaghisini Anche questa è da approvare |
giuliaghisini
requested changes
Sep 3, 2024
src/components/ItaliaTheme/Blocks/VideoGallery/Block/ViewBlock.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/Blocks/VideoGallery/Block/ViewBlock.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/Blocks/VideoGallery/Block/ViewBlock.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/Blocks/VideoGallery/Block/ViewBlock.jsx
Outdated
Show resolved
Hide resolved
|
@giuliaghisini il corretto, allora, è lasciare la condizione solo a chi ha |
no, quello non centra nulla con la caption del video |
giuliaghisini
requested changes
Sep 4, 2024
src/components/ItaliaTheme/Blocks/VideoGallery/Block/ViewBlock.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Giulia Ghisini <[email protected]>
|
@giuliaghisini dovrebbe essere ok adesso, riesci a fare una ulteriore verifica, per favore? |
giuliaghisini
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cambiata label per la didascalia video
Aggiunto checkbox per mostrare o meno la didascalia
https://redturtle.tpondemand.com/entity/57952-gallery-video