fix: use maxLength/forceMaxLength in CharCounterTextareaWidget #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamico
changed the title
|
riporto la PR #88 dove è stato introdotto il codice, non vedo descritti motivi particolari che giustifichino quella scelta. |
giuliaghisini
requested changes
Jul 12, 2024
src/components/ItaliaTheme/manage/Widgets/CharCounterTextareaWidget.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/manage/Widgets/CharCounterTextareaWidget.jsx
Outdated
Show resolved
Hide resolved
pnicolli
requested changes
Jul 12, 2024
src/components/ItaliaTheme/manage/Widgets/CharCounterTextareaWidget.jsx
Outdated
Show resolved
Hide resolved
giuliaghisini
approved these changes
Sep 5, 2024
|
@pnicolli a modena servirebbe questa cosa |
|
@giuliaghisini Sì ma con @mamico avevamo fatto altri ragionamenti su slack, c'erano attività in sospeso. Ti scrivo in privato. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nella componente della textarea il maxLength veniva completamente ignorato nel fare trim del testo e usato sempre 255