Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "/diff" regexp #696

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Fix "/diff" regexp #696

merged 1 commit into from
Jun 11, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Jun 10, 2024

Better handle /diff route regexp as non-content route because otherwise "cms-ui" styles are applied also on contents that starts with "diff" like "diffusione".

… cms-ui styles are applied also on contents that starts with "diff" like "diffusione".
@giuliaghisini
Copy link

il problema era che se avevamo un url dove nel path c'era scritto "diff" veniva applicata al body la classe cms-ui e quindi si vedevano degli stili strani anche nella pagina in view.
Ad esempio se l'url era /pippo/pluto/difficolta.

Copy link
Member

@pnicolli pnicolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvo, ma serve fare una PR anche su volto o siamo da capo con tutti i siti che faremo.

@pnicolli pnicolli merged commit 027b569 into main Jun 11, 2024
3 checks passed
@pnicolli pnicolli deleted the fix_diff_route branch June 11, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants