forked from italia/design-comuni-plone-theme
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added arrow icon to links in footerNavigation #642
Open
sabrina-bongiovanni
wants to merge
4
commits into
v2
Choose a base branch
from
us_53982_v2_identificazione_elementi
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrina-bongiovanni
added
a11y-accessibility
Fixes accessibility issues or adds accessibility features
v2
labels
Apr 9, 2024
Wagner3UB
reviewed
Apr 10, 2024
@@ -73,6 +74,7 @@ const FooterNavigation = () => { | |||
} | |||
> | |||
{item.title} | |||
<Icon icon="it-arrow-right" color="white" /> | |||
</Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
</Link> | |
<Link | |
to={item.url} | |
title={ | |
intl.formatMessage(messages.goToPage) + ': ' + item.title | |
} | |
> | |
<SectionIcon | |
section={item.url} | |
iconProps={{ size: 'sm', color: 'white', className: 'mr-2' }} | |
/> | |
{item.title} | |
<Icon icon="it-arrow-right" color="white" size="sm" /> | |
</Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tranne questo, forse dare una classe al link per il display flex
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Wagner3UB
Le WCAG non parlano espressamente di icone ma di non-color designators, ma si limitano a listare caratteristiche e stili di font come boldness, italics, etc.
Facendo qualche ricerca, sembra che le icone possano essere usate come "non-color designators" per link. Reference:
https://www.freecodecamp.org/news/link-accessibility-colors-are-not-enough/ (punto 3, icons)
https://usability.yale.edu/web-accessibility/articles/links#:~:text=The%20easiest%20way%20to%20provide,option%20includes%20having%20an%20icon