fix: aria-label in calendar block controls #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deodorhunter
added
the
a11y-accessibility
pnicolli
approved these changes
Mar 27, 2024
Wagner3UB
reviewed
Mar 27, 2024
| icon={['fas', 'chevron-left']} | ||
| title={intl.formatMessage(messages.calendar_next_arrow)} |
There was a problem hiding this comment.
- Siamo sicuri di aver bisogno di questo title dentro al pulsante? Non basta l'aria-label su button? Ho fatto un test veloce e lo SR legge solo l'aria-label
- Se il title è giusto, il corretto qui sarebbe "_prev_arrow"
There was a problem hiding this comment.
Hai ragione sul punto 2, bisogna che lo correggiamo @deodorhunter, mi è sfuggito.
Per il punto 1, ahimè dobbiamo metterlo. Non serve a niente per lo screen reader ma il tool che usiamo per il test (MAUVE++) vuole le aria-label in tutte le icone, anche se hanno aria-hidden. È inutile, ma non possiamo farci niente.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.