Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added aria-label for cardReadMore component in iconBlock #618

Merged
merged 3 commits into from
Apr 8, 2024
Merged

fix: added aria-label for cardReadMore component in iconBlock #618

merged 3 commits into from
Apr 8, 2024

Conversation

sabrina-bongiovanni
Copy link
Collaborator

Non ho aggiornato il release.md perchè c'è già un'altra pr che aggiunge l'info sulle migliorie all'accessibilità di del blocco icone

@sabrina-bongiovanni sabrina-bongiovanni self-assigned this Mar 27, 2024
@sabrina-bongiovanni sabrina-bongiovanni added the a11y-accessibility Fixes accessibility issues or adds accessibility features label Mar 27, 2024
@sabrina-bongiovanni
Copy link
Collaborator Author

@Wagner3UB

@sabrina-bongiovanni
Copy link
Collaborator Author

@deodorhunter @pnicolli
Ho dovuto creare una stringa creando un renderer per redraft ad hoc per estrarre una semplice stringa, i renderer di ioComune producono un elemento html che dentro l'aria label non va bene
Testandolo in locale con anche più di una card nel blocco non dà problemi, tutte le aria-label si costruiscono nella maniera corretta

@pnicolli pnicolli merged commit 77cfb05 into main Apr 8, 2024
5 checks passed
@pnicolli pnicolli deleted the us_51454_v3_scopo_dei_link branch April 8, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deodorhunter deodorhunter deodorhunter requested changes

@pnicolli pnicolli pnicolli approved these changes

Assignees

@sabrina-bongiovanni sabrina-bongiovanni

Labels
a11y-accessibility Fixes accessibility issues or adds accessibility features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabrina-bongiovanni @pnicolli @deodorhunter