Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translated aria-label of menu hamburger icon #592

Merged
merged 7 commits into from
Apr 3, 2024
+121 −2
Merged

fix: translated aria-label of menu hamburger icon #592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85a60ba
fix: translated aria-label of menu hamburger icon
sabrina-bongiovanni Mar 15, 2024
9a0d9a1
fix: used collapseOpen variable to change aria-label message
sabrina-bongiovanni Mar 18, 2024
23789fe
chore: removed console.log
sabrina-bongiovanni Mar 18, 2024
a4fc853
fix: added translations for toggleMenu
sabrina-bongiovanni Mar 27, 2024
4dd4643
Merge branch 'v2' into us_51462_v2_menu_hamburger_icon_aria_label
sabrina-bongiovanni Apr 3, 2024
07ad73c
fix: added EN translations
sabrina-bongiovanni Apr 3, 2024
c267ead
chore: changed release.md
sabrina-bongiovanni Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
- ...
-->

## Versione X.X.X (dd/mm/yyyy)

### Fix

- Tradotto il messaggio per Screen Reader del bottone per aprire e chiudere il menu in mobile.

## Versione 7.25.3 (07/03/2024)

### Migliorie
Expand Down
6 changes: 5 additions & 1 deletion src/customizations/volto/components/theme/Navigation/Navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const Navigation = ({ pathname }) => {
<HeaderToggler
aria-controls="it-navigation-collapse"
aria-expanded={collapseOpen}
aria-label="Toggle navigation"
aria-label={intl.formatMessage(messages.ToggleMenu)}
pnicolli marked this conversation as resolved.
Show resolved Hide resolved
onClick={() => {
setCollapseOpen(!collapseOpen);
setFocusTrapActive(!focusTrapActive);
Expand Down Expand Up @@ -175,6 +175,10 @@ const messages = defineMessages({
id: 'close-menu',
defaultMessage: 'Chiudi menu',
},
ToggleMenu: {
id: 'toggle-menu',
defaultMessage: 'Apri o chiudi il menu',
},
});

Navigation.propTypes = {
Expand Down
Loading