fix: added aria label to icons across ioComune #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnicolli
added
the
a11y-accessibility
deodorhunter
requested changes
Mar 25, 2024
|
@sabrina-bongiovanni ci sono nuovi conflitti dovuti all'altro aggiornamento sull'aria-hidden delle icone |
pnicolli
requested changes
Mar 27, 2024
There was a problem hiding this comment.
C'è un motivo per cui hai preferito title a aria-label? Per capire di essere allineati sul discorso, perché so che abbiamo discusso entrambe le ipotesi in passato e usato entrambe ma ora usiamo aria-label ovunque a meno che non sia necessario il title per altri motivi.
src/components/ItaliaTheme/Blocks/Accordion/Block/ViewBlock.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/Blocks/Common/SearchFilters/DateFilter.jsx
Outdated
Show resolved
Hide resolved
src/components/ItaliaTheme/View/EventoView/EventoContattiOrganizzatoreEsterno.jsx
Outdated
Show resolved
Hide resolved
pnicolli
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggiunti alt a tutti gli elementi richiesti da Mauve
So che alcuni alt non verranno mai letti perchè hanno "aria-hidden" = "true" e perchè sono parte di elementi non leggibili da SR, ma Mauve li segnala comunque
non ho aggiornato il release.md perchè ai clienti non cambierà proprio niente, è una modifica che non fa nulla essenzialmente