Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed semantic headings levels in rss templates, all h3 now #521

Merged
merged 3 commits into from
Feb 8, 2024
Merged

fix: fixed semantic headings levels in rss templates, all h3 now #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
833e43a
fix: fixed semantic headings levels in rss templates, all h3 now
deodorhunter Feb 2, 2024
dc1d604
fix: use h6 classname in h3 card title to preserve aspect
deodorhunter Feb 5, 2024
6314e9c
Merge branch 'main' into a11y_rss_template_card_headings
pnicolli Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
- Reso il link ai diversi social elencati parlante, ora viene riportato "Seguici su nome_del_social"
- Rimossi gli heading per alcuni blocchi nel caso il titolo non sia presente al fine di migliorare l'esperienza con l'uso di screen reader
- Migliorata l'accessibilità per il blocco Contenuti in Evidenza e per i bottoni nei sottositi
- Sistemato l'html semantico degli heading per i template del Blocco Listing variazione RSS, migliorata l'esperienza d'uso per gli utenti che utilizzano screen reader

## Versione 11.4.0 (06/02/2024)

Expand Down
4 changes: 3 additions & 1 deletion src/components/ItaliaTheme/Blocks/RssBlock/CardWithImageRssTemplate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ const CardWithImageRssTemplate = ({
{getViewDate(item.pubDate || item.date, intl.locale)}
</span>{' '}
</div>
<CardTitle tag="h6">{item.title}</CardTitle>
<CardTitle tag="h3" className="h6">
{item.title}
</CardTitle>
{item?.source?.length > 0 && (
<div className="source-title">
<span className="source">{item.source}</span>
Expand Down
4 changes: 3 additions & 1 deletion src/components/ItaliaTheme/Blocks/RssBlock/CardWithoutImageRssTemplate.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ const CardWithoutImageRssTemplate = ({
</span>
)}
</div>
<CardTitle tag="h5">{item.title}</CardTitle>
<CardTitle tag="h3" className="h6">
{item.title}
</CardTitle>
{item?.source?.length > 0 && (
<div className="source-title">
<span className="source">{item.source}</span>
Expand Down
2 changes: 1 addition & 1 deletion ...onents/ItaliaTheme/Blocks/RssBlock/TemplatesSkeleton/CardWithImageRssTemplateSkeleton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const CardWithImageRssTemplateSkeleton = ({ isEditMode, data = {} }) => {

<CardBody tag="div" className="px-4">
<div className="category-top"></div>
<CardTitle tag="h6"></CardTitle>
<CardTitle tag="h3" className="h6"></CardTitle>
</CardBody>
<CardReadMore
iconName="it-arrow-right"
Expand Down
2 changes: 1 addition & 1 deletion ...nts/ItaliaTheme/Blocks/RssBlock/TemplatesSkeleton/CardWithoutImageRssTemplateSkeleton.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const CardWithoutImageRssTemplateSkeleton = ({ isEditMode, data = {} }) => {
<Card noWrapper={false} tag="div">
<CardBody tag="div">
<div className="category-top"></div>
<CardTitle tag="h5"></CardTitle>
<CardTitle tag="h3" className="h6"></CardTitle>
<CardText tag="p" className="font-serif"></CardText>
</CardBody>
<CardReadMore
Expand Down
Loading