Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not show empty headings if title in block is not configured #517

Merged
merged 2 commits into from
Feb 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@

### Fix

- [ Accessibilità ] Rimossi gli heading per alcuni blocchi nel caso il titolo non sia presente al fine di migliorare l'esperienza con l'uso di screen reader
- Sistemata la gerarchia per i titoli dentro al blocco semplice

## Versione 11.3.4 (31/01/2024)
Expand Down
4 changes: 3 additions & 1 deletion src/components/ItaliaTheme/Blocks/CountDown/Body.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ const Body = ({ block, sections, data }) => {
<SearchSectionsBackground />
<div className="container">
<div className="searchContainer d-flex w-100">
<h2 className="text-secondary mb-4">{block.title}</h2>
{block.title && (
<h2 className="text-secondary mb-4">{block.title}</h2>
)}
<div className="searchbar lightgrey-bg-c2 shadow-sm rounded d-flex w-100">
<input
className="inputSearch lightgrey-bg-c2"
Expand Down
4 changes: 3 additions & 1 deletion src/components/ItaliaTheme/Blocks/SearchSections/Body.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ const Body = ({ block, sections }) => {
)}
<div className="container">
<div className="searchContainer d-flex w-100">
<h2 className="search-section-title mb-4">{block.title}</h2>
{block.title && (
<h2 className="search-section-title mb-4">{block.title}</h2>
)}
<div className="searchbar shadow-sm rounded d-flex w-100">
<button
className="rounded-start"
Expand Down
Loading