Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple card title changed from h4 to h3 #514

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Simple card title changed from h4 to h3 #514

merged 3 commits into from
Feb 5, 2024

Conversation

Wagner3UB
Copy link

Due to respect for the HTML hierarchy, the title of the simple card was changed to h3

  • RER request - us51097

@Wagner3UB Wagner3UB self-assigned this Feb 2, 2024
pnicolli
pnicolli requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@pnicolli pnicolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fare questa modifica va bene per l'accessibilità, ma va ad alterare l'aspetto della card, rendendo il titolo più grande e più grosso. Prova ad aggiungere la classe h4, dovrebbe restare visivamente come prima anche se adesso è un h3.

@Wagner3UB
Copy link
Author

@pnicolli Hai ragione, fatto
Screenshot 2024-02-02 at 12 58 57

@Wagner3UB Wagner3UB requested a review from pnicolli February 2, 2024 12:00
@Wagner3UB
Copy link
Author

@deodorhunter

@deodorhunter deodorhunter self-requested a review February 5, 2024 13:24
@deodorhunter
Copy link

@Wagner3UB release.md e poi possiamo mergiare

@deodorhunter deodorhunter added the a11y-accessibility Fixes accessibility issues or adds accessibility features label Feb 5, 2024
@Wagner3UB
Copy link
Author

@deodorhunter fatto. Non pensavo fosse necessario, sry

@deodorhunter deodorhunter merged commit c03f4cd into main Feb 5, 2024
3 checks passed
@deodorhunter deodorhunter deleted the us51097-title-hierarchy-simpleCard branch February 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuliaghisini giuliaghisini giuliaghisini approved these changes

@deodorhunter deodorhunter deodorhunter approved these changes

@pnicolli pnicolli pnicolli approved these changes

Assignees

@Wagner3UB Wagner3UB

Labels
a11y-accessibility Fixes accessibility issues or adds accessibility features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wagner3UB @deodorhunter @pnicolli @giuliaghisini