Ricerca in testata applica filtri sezione #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrina-bongiovanni
changed the title
sabrina-bongiovanni
changed the title
pnicolli
reviewed
Nov 14, 2023
Comment on lines
+72
to
+74
| (customPath.length === 0 | ||
| ? `&custom_path=${flattenToAppURL(path)}` | ||
| : ''); |
There was a problem hiding this comment.
@sabrina-bongiovanni ho lasciato anche la vecchia implementazione per permettere l'utilizzo della ricerca in testata anche nelle pagine che non sono tra le quattro sezioni di ricerca, che è una cosa che prima era possibile quindi non dobbiamo togliere
Comment on lines
30
to
+34
| const intl = useIntl(); | ||
| const path = content['@id']; | ||
| const searchFilters = useSelector( | ||
| (state) => state?.searchFilters?.result?.sections, | ||
| ); |
There was a problem hiding this comment.
Ho rimosso il dispatch perché quella query per search-filters viene già fatta a prescindere ogni volta che si visita il sito, era duplicata. Ho lasciato anche useIntl in cima, la convenzione vuole che gli hook stiano il più possibile in alto nel componente e quelli semplici tipo useIntl cerchiamo di tenerli sempre in cima.
| } else { | ||
| if (path === section['@id']) { | ||
| customPath.push( | ||
| section.items.map((item) => flattenToAppURL(item['@id'])), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.