Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i link in modulistica devono far vedere la remoteUrl e non il link (v2) #334

Merged
merged 2 commits into from
Sep 19, 2023
Merged

fix: i link in modulistica devono far vedere la remoteUrl e non il link (v2) #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34bc1b2
fix: i link in modulistica devono far vedere la remoteUrl e non il link
mamico Sep 18, 2023
f203557
doc: releaselog
mamico Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@

### Migliorie

Aggiunto limite di caratteri agli input della descrizione
- Aggiunto limite di caratteri agli input della descrizione

### Fix

- Sistemato il problema per cui nell'area modulistica eventuali link che puntano
a file non aprivano il file ma una pagina bianca del sito

<!--- -->

Expand Down
6 changes: 3 additions & 3 deletions src/components/ItaliaTheme/View/CartellaModulisticaView/DocRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ const Downloads = ({ item, titleDoc }) => {
</React.Fragment>
) : (
<UniversalLink
href={flattenToAppURL(item['@id'])}
href={item.remoteUrl || flattenToAppURL(item['@id'])}
title={item.title}
className="modulistica-link"
>
Expand All @@ -59,7 +59,7 @@ const DocRow = ({ doc, items }) => {
})}
>
<div id={`title-${doc.id}`} className="title">
<UniversalLink href={flattenToAppURL(doc['@id'])}>
<UniversalLink href={doc.remoteUrl || flattenToAppURL(doc['@id'])}>
{doc.title}
</UniversalLink>
{doc?.description && (
Expand All @@ -77,7 +77,7 @@ const DocRow = ({ doc, items }) => {
key={doc['@id']}
>
{/*Only title and/or description, no files */}
{(!items || items.length == 0) && (
{(!items || items.length === 0) && (
mamico marked this conversation as resolved.
Show resolved Hide resolved
<div className="doc">{titleWrapper}</div>
)}

Expand Down