refactor: factor out text handling as new modules Text
and Loctext
#159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Diagnostic
module bundles diagnostics and text operations together. The planned lower-level debugging interface #138 could reuse text operations but not (high-level) diagnostics. This PR factors out text operations as new modulesText
andLoctext
so that the debugging interface does not have to depend on theDiagnostic
module.Here are all the bindings being moved:
Diagnostic.text
(type)Text.t
Diagnostic.text
(function)Text.make
Diagnostic.textf
Text.makef
Diagnostic.ktextf
Text.kmakef
Diagnostic.loctext
(type)Loctext.t
Diagnostic.loctext
(function)Loctext.make
Diagnostic.loctextf
Loctext.makef
Diagnostic.kloctextf
Loctext.kmakef
Diagnostic.string_of_text
Text.to_string