Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: lowercase almost everything #118

Merged
merged 4 commits into from
Oct 23, 2023
Merged

docs: lowercase almost everything #118

merged 4 commits into from
Oct 23, 2023

Conversation

favonia
Copy link
Contributor

@favonia favonia commented Oct 23, 2023

Close #115.

@mikeshulman
Copy link
Collaborator

Is it also recommended for the user that error messages be all lowercase?

@favonia
Copy link
Contributor Author

favonia commented Oct 23, 2023

Is it also recommended for the user that error messages be all lowercase?

@mikeshulman I haven't made up my mind on this. Lowercase messages seem more "composable" with other things, but I don't feel strongly enough about them to enforce anything. Do you have an opinion about what or what not to do?

@mikeshulman
Copy link
Collaborator

This is not something that I want to expend any energy on having an opinion about. I'm already spending more time and energy than I ought to on things like error reporting, parsing, and pretty-printing. (-:

@favonia
Copy link
Contributor Author

favonia commented Oct 23, 2023

@mikeshulman then it seems that lowercase messages without ending punctuations can't go wrong

@favonia favonia merged commit ea35418 into main Oct 23, 2023
2 checks passed
@favonia favonia deleted the lowercase branch October 23, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔡 error message lettercase convention
2 participants