Provide copyable text for exercises + minor style fixes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
psolarvi
approved these changes
Dec 12, 2023
Comment on lines
+258
to
+259
| $ podman build -t purchase-predictor:1.0 . | ||
| $ podman tag purchase-predictor:1.0 quay.io/user_name/purchase-predictor:1.0 |
There was a problem hiding this comment.
Not a blocker comment, but why creating 2 tags for the same container image?
Why not using the FQN tag in the build step?
There was a problem hiding this comment.
Maybe for clarity? We would have to ask the original writer of the exercise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback:
I have also standardized the console block format.