-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHODS Users Section #4
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! Please address my comments:
- As per comments in previous sections PR, please split into initial 2 or 3 paras of theory narrative ad then add an exercise sub-section, followed by a References at the bottom
- Numbered steps for exercise.
- Any oc CLI tips? for troubleshooting, checking, validating etc etc
- Explain more clearly the relationship between OCP parts of users and roles and RHODS users and groups
I'm unsure what this is referring to.
Updated, let me know if this is what you were looking for
I added a small exercise at the end. I'm not sure that this section lends itself very well to exercises. Let me know if you have a suggestion for an additional exercise. Also, I'm not exactly sure how to approach setting up the exercises without any context for what the exercise environment will be or what will be setup for users out of the box.
Not sure what you mean by this. Are you looking for a list of additional references for links to other things talking about this? I provided a few relevant links to some docs that covered topics I felt fell outside of the scope of this course throughout the page so I'm not sure if you are looking to just repeat those links at the bottom.
I'm not sure what all would be relevant here. If you have any specific items that you see that could use some additional info for these let me know.
I tried to clear up a bit. Let me know if that helps. |
@rsriniva Please take a look at my comments above. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is very well written and with lots of details. Good job @strangiato! I have just added a couple of minor comments for you to consider, but no need for rereview. You can go ahead and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now. Let's merge this after resolving the merge conflicts
No description provided.