Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHODS Users Section #4

Merged
merged 21 commits into from
Nov 16, 2023
Merged

RHODS Users Section #4

merged 21 commits into from
Nov 16, 2023

Conversation

strangiato
Copy link
Collaborator

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-16 00:31 UTC

@strangiato strangiato marked this pull request as ready for review October 21, 2023 00:40
@rsriniva rsriniva self-requested a review October 24, 2023 03:27
Copy link
Contributor

@rsriniva rsriniva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! Please address my comments:

  • As per comments in previous sections PR, please split into initial 2 or 3 paras of theory narrative ad then add an exercise sub-section, followed by a References at the bottom
  • Numbered steps for exercise.
  • Any oc CLI tips? for troubleshooting, checking, validating etc etc
  • Explain more clearly the relationship between OCP parts of users and roles and RHODS users and groups

@strangiato
Copy link
Collaborator Author

  • As per comments in previous sections PR,

I'm unsure what this is referring to.

please split into initial 2 or 3 paras of theory narrative

Updated, let me know if this is what you were looking for

add an exercise sub-section,

I added a small exercise at the end. I'm not sure that this section lends itself very well to exercises. Let me know if you have a suggestion for an additional exercise.

Also, I'm not exactly sure how to approach setting up the exercises without any context for what the exercise environment will be or what will be setup for users out of the box.

followed by a References at the bottom

Not sure what you mean by this. Are you looking for a list of additional references for links to other things talking about this? I provided a few relevant links to some docs that covered topics I felt fell outside of the scope of this course throughout the page so I'm not sure if you are looking to just repeat those links at the bottom.

  • Any oc CLI tips? for troubleshooting, checking, validating etc etc

I'm not sure what all would be relevant here. If you have any specific items that you see that could use some additional info for these let me know.

  • Explain more clearly the relationship between OCP parts of users and roles and RHODS users and groups

I tried to clear up a bit. Let me know if that helps.

@strangiato
Copy link
Collaborator Author

@rsriniva Please take a look at my comments above.

@jhurlocker
Copy link
Collaborator

Copy link
Collaborator

@jramcast jramcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is very well written and with lots of details. Good job @strangiato! I have just added a couple of minor comments for you to consider, but no need for rereview. You can go ahead and merge.

modules/chapter2/pages/users.adoc Outdated Show resolved Hide resolved
modules/chapter2/pages/users.adoc Outdated Show resolved Hide resolved
modules/chapter2/pages/users.adoc Outdated Show resolved Hide resolved
modules/chapter2/pages/users.adoc Outdated Show resolved Hide resolved
modules/chapter2/pages/users.adoc Outdated Show resolved Hide resolved
modules/chapter2/pages/users.adoc Show resolved Hide resolved
@rsriniva rsriniva self-requested a review November 15, 2023 00:54
Copy link
Contributor

@rsriniva rsriniva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. Let's merge this after resolving the merge conflicts

@strangiato strangiato merged commit 285fb1f into main Nov 16, 2023
1 check passed
@strangiato strangiato deleted the user-admin branch November 16, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants