Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHIENG-9113 fixed jest config and added unit tests #331

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

PreetiW
Copy link
Contributor

@PreetiW PreetiW commented Apr 23, 2024

PR Title 💥

Migrated unit tests from Enzym to React Testing Library.

Why do we need this change? 💭

Please include the context of this change here.

Documentation requires update? 📝

  • Yes
  • No

Security Checklist 🔒

Upon raising this PR please go through RedHatInsights/secure-coding-checklist

💂‍♂️ Checklist 🎯

  • Bugfix
  • New Feature
  • Refactor
  • Unittests Added
  • DRY code
  • Dependency Added

Additional 📣

Feel free to add any other relevant details such as links, notes, screenshots, here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 19.44%. Comparing base (da029b2) to head (c190e13).
Report is 1 commits behind head on main.

Current head c190e13 differs from pull request most recent head c2dfaf2

Please upload reports for the commit c2dfaf2 to get more accurate results.

Files Patch % Lines
src/Routes/RosSystemDetail/RosSystemDetail.js 0.00% 2 Missing ⚠️
src/App.js 0.00% 1 Missing ⚠️
...uggestedInstanceTypes/RosSuggestedInstanceTypes.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #331       +/-   ##
==========================================
+ Coverage   8.11%   19.44%   +11.32%     
==========================================
  Files         47       45        -2     
  Lines        973      972        -1     
  Branches     183      183               
==========================================
+ Hits          79      189      +110     
+ Misses       836      732      -104     
+ Partials      58       51        -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PreetiW PreetiW added the WIP label May 13, 2024
@PreetiW PreetiW marked this pull request as ready for review May 15, 2024 11:08
Copy link
Contributor

@r14chandra r14chandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @PreetiW! I have requested some changes. Have a look.

src/Components/SystemDetail/RecommendationsTable.test.js Outdated Show resolved Hide resolved
src/Components/Reports/Common/SystemsTablePage.test.js Outdated Show resolved Hide resolved
src/Components/Reports/Common/SystemsFirstPage.test.js Outdated Show resolved Hide resolved
src/Components/Reports/Common/SystemsFirstPage.test.js Outdated Show resolved Hide resolved
src/Components/Reports/Common/SystemsFirstPage.test.js Outdated Show resolved Hide resolved
@PreetiW PreetiW requested a review from r14chandra June 14, 2024 07:47
Copy link
Contributor

@r14chandra r14chandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks good now. Just suggested one change.

Copy link
Contributor

@r14chandra r14chandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@r14chandra r14chandra merged commit 369b56b into RedHatInsights:main Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants