main >> prod-beta #297
Merged
main >> prod-beta #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* RHIROS-492 upgrade react-router-dom to v6 * add piplock file and upgrade packages * fix routes * add webpack-cli * use InsightsLink component and useLocation and useParams hooks * update tests * remove withRouter HOC * update FEC package version * add babel-runtime package * fix lodash-es error * add fast-text-encoding polyfill package
* RHIROS-1163 add suggested instance types table with static data * RHIROS-1222 integrate with /suggested_instance_types endpoint * handle UI for errors, change action type naming * use error object
updated README.md
* fix(RHINENG-3653): Update Groups column default text * replace additional N/A Text
* RHIROS-1164 implement sorting on suggested instance types table * code refactor
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## prod-beta #297 +/- ##
=============================================
- Coverage 20.54% 20.10% -0.45%
=============================================
Files 45 47 +2
Lines 915 965 +50
Branches 170 181 +11
=============================================
+ Hits 188 194 +6
- Misses 676 721 +45
+ Partials 51 50 -1 ☔ View full report in Codecov by Sentry. |
* RHIROS-1302 enable group sorting * code refactor - moved groups object to constant file
r14chandra
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main >> prod-beta 💥
main >> prod-beta
Feel free to remove this section from PR description once done.
Why do we need this change? 💭
Please include the context of this change here.
Documentation requires update? 📝
Security Checklist 🔒
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
💂♂️ Checklist 🎯
Additional 📣
Feel free to add any other relevant details such as links, notes, screenshots, here.