fix(RHINENG-3653): Update Groups column default text #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkarat
reviewed
Nov 29, 2023
PreetiW
requested changes
Nov 30, 2023
There was a problem hiding this comment.
Thank you for creating the MR @adonispuente. I have left a comment regarding the change. 💯
|
@PreetiW could you take another look, ive added to recommend changes |
PreetiW
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Thank you for making changes @adonispuente, looks good to me now. LGTM 🚀
|
@PreetiW could you also merge when you get a chance? I dont have perms to do so for ROS |
|
Sure @adonispuente merging it 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the text for when a system has no group from 'N/A' to 'No group' in grey wording. In this particular case, just in the systemPDF report
https://issues.redhat.com/browse/RHINENG-3653