RHIROS-1302 enable group sorting #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 20.33% 20.35% +0.02%
==========================================
Files 47 47
Lines 954 953 -1
Branches 179 179
==========================================
Hits 194 194
+ Misses 712 711 -1
Partials 48 48 ☔ View full report in Codecov by Sentry. |
|
@yash2189 can you test this PR? |
PreetiW
force-pushed
the
RHIROS-1302-enable-group-sorting
branch
from
cca3aa8 to
8b5623d
Compare
PreetiW
force-pushed
the
RHIROS-1302-enable-group-sorting
branch
from
8b5623d to
7fdd5df
Compare
|
@r14chandra I pushed few changes after your review, can you please have a look into PR again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable group sorting 💥
Jira: https://issues.redhat.com/browse/RHIROS-1302
Why do we need this change? 💭
Please include the context of this change here.
Documentation requires update? 📝
Security Checklist 🔒
Upon raising this PR please go through RedHatInsights/secure-coding-checklist
💂♂️ Checklist 🎯
Additional 📣
Feel free to add any other relevant details such as links, notes, screenshots, here.