Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compliance): RHINENG-8964 allow listing/assigning policies #4209

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Sep 9, 2024

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

@LightOfHeaven1994
Copy link
Contributor

Tested it with custom egg, everything works as expected! thank you @xiangce . We will need to wait before merging this one since we haven't released APIv2 fully to prod yet

@skateman
Copy link
Member

Thank you @xiangce, I will go through this after my PTO.

@xiangce xiangce added app Apps embedded in the Insights Core collection labels Oct 17, 2024
@xiangce xiangce marked this pull request as ready for review November 26, 2024 05:28
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 68.53147% with 45 lines in your changes missing coverage. Please review.

Project coverage is 77.17%. Comparing base (d5507ad) to head (76693ad).

Files with missing lines Patch % Lines
...ghts/specs/datasources/compliance/compliance_ds.py 53.94% 34 Missing and 1 partial ⚠️
insights/specs/datasources/compliance/__init__.py 83.05% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4209      +/-   ##
==========================================
- Coverage   77.20%   77.17%   -0.04%     
==========================================
  Files         764      764              
  Lines       41550    41630      +80     
  Branches     8783     8789       +6     
==========================================
+ Hits        32079    32127      +48     
- Misses       8413     8442      +29     
- Partials     1058     1061       +3     
Flag Coverage Δ
unittests 77.15% <68.53%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romanblanco
Copy link
Member

@xiangce @skateman is this ready to be merged?

@skateman
Copy link
Member

We have performance issues...

Signed-off-by: Xiangce Liu <[email protected]>
- and commit update made by black

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Apps embedded in the Insights Core collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants