-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 11ty image plugin for image optimization #79
Draft
zeroedin
wants to merge
12
commits into
main
Choose a base branch
from
feat/add-eleventy-img
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Deploy Preview for prismatic-souffle-43beb6 failed.
|
zeroedin
changed the title
feat: add 11ty image plugin for image optomization
feat: add 11ty image plugin for image optimization
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
eleventy-img
plugin which helps optimize image loading by providing correct height and width for images and enables defaults ofloading="lazy"
rhb-img
component that uses the webc based implementation of theeleventy-img
plugin. Modified to always output the same format as the extension of the image. As well as provide adata-attr
to track the original src to help link the hashed image.public
folder in favor of justassets
. This helps align the webc expectation of a local path in thesrc
before transformation instead of a standard img tags end source of/assets/*
alt
attributes on images withalt="[ERROR: MISSING ALT TAG]"
these will need resolved before merging see Missing alt tags #78assets/posters
as they are not standard images.rollup.config
to match pathing changesfont-display: swap;
to font css as a Lighthouse optimization.Closes #38
TODO:
alt
tags with proper descriptive textTesting instructions