Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rocky Linux 9 support #231

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

debovema
Copy link
Contributor

@debovema debovema commented Dec 6, 2022

Description

Checklist/ToDo's

  • Added documentation? N/A, behaviour not changed
  • Added release note entry? ( docs/release-notes.md )
  • Tested? Yes, on a Scaleway bare metal server

@debovema debovema marked this pull request as ready for review December 7, 2022 10:40
@rbo
Copy link
Contributor

rbo commented Dec 7, 2022

How do you instal Rocky 9? Looks like basis image is not available from hetzner:

root@rescue ~ # ls -1 images/{CentOS,Rocky}*
images/CentOS-79-64-minimal.tar.gz
images/CentOS-79-64-minimal.tar.gz.sig
images/CentOS-80-stream-amd64-base.tar.gz
images/CentOS-80-stream-amd64-base.tar.gz.sig
images/CentOS-85-64-minimal.tar.gz
images/CentOS-85-64-minimal.tar.gz.sig
images/Rocky-85-amd64-base.tar.gz
images/Rocky-85-amd64-base.tar.gz.sig
root@rescue ~ # 

@debovema
Copy link
Contributor Author

debovema commented Dec 7, 2022

I used this repository to create an OCP cluster on an already provisioned bare metal server running Rocky 9 (on Scaleway btw, not Hetzner).
Maybe this repository should be renamed libvirt-ocp4 and leave the 00-provision-hetzner.yml playbook optional ?

@rbo
Copy link
Contributor

rbo commented Dec 7, 2022

Good point, I have already thought about renaming it, but I am not clear about the impact.

@debovema
Copy link
Contributor Author

debovema commented Dec 7, 2022

They call it the "Danger Zone" but it's not that dangerous I think since when you rename a repo, the old name redirects on the new one.
For instance see https://github.com/debovema/DO288-applications which I renamed from https://github.com/debovema/DO288-apps (forked from https://github.com/RedHatTraining/DO288-apps). The

This repo (I mean https://github.com/RedHat-EMEA-SSA-Team/hetzner-ocp4) is very interesting as it bridges the gap between do-it-yourself, tedious, bare-metal installation and the "too limited" OpenShift Local (formerly CodeReady Containers).

The main drawback I find however is the prioritization of information for a newcomer.
For instance:

  • do we really need Hetzner machines ? short answer seems to be no
  • can we execute the playbooks remotely (from our laptop) ? it seems that yes but I had difficulties so I run it from the server directly

I'm experiencing the repo in-depth and doing some PR (add Gandi DNS Provider for example).

Then I can help to update documentation if you want.

@rbo rbo mentioned this pull request Dec 8, 2022
4 tasks
@rbo
Copy link
Contributor

rbo commented Dec 8, 2022

@debovema Let's move the renaming discussion into an own Issue #232

@rbo
Copy link
Contributor

rbo commented Dec 12, 2022

@debovema Can you be so kind and update (rebase) to the latest devel tree version?

@debovema debovema force-pushed the rocky-9 branch 2 times, most recently from 497048e to dc2f464 Compare December 12, 2022 13:59
@debovema
Copy link
Contributor Author

@debovema Can you be so kind and update (rebase) to the latest devel tree version?

Done

@rbo
Copy link
Contributor

rbo commented Dec 12, 2022

/test

@rbo
Copy link
Contributor

rbo commented Dec 16, 2022

/test

@rbo rbo merged commit 89fd54a into RedHat-EMEA-SSA-Team:devel Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants