Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages in contact form #29

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Better error messages in contact form #29

merged 3 commits into from
Jan 8, 2020

Conversation

Ugoku
Copy link
Member

@Ugoku Ugoku commented Oct 16, 2019

Refs #20

@Ugoku Ugoku force-pushed the 20-contactform-errors branch from 9199ab6 to 0f21d9e Compare December 4, 2019 16:06
nederdirk
nederdirk previously requested changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@nederdirk nederdirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Tests probably need a bit more attention. A good deprecation policy (including support windows for old versions, downstream communication, etc) would be most welcome, too!

src/contactForm.js Outdated Show resolved Hide resolved
src/contactForm.js Outdated Show resolved Hide resolved
test/js-unit/recrasContactFormSpec.js Show resolved Hide resolved
src/contactForm.js Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
@Ugoku Ugoku requested a review from timmipetit January 6, 2020 16:08
@Ugoku Ugoku dismissed nederdirk’s stale review January 6, 2020 16:08

Not available for a few weeks

@timmipetit timmipetit merged commit 9922973 into master Jan 8, 2020
@timmipetit timmipetit deleted the 20-contactform-errors branch January 8, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nederdirk nederdirk nederdirk left review comments

@timmipetit timmipetit Awaiting requested review from timmipetit

Assignees

@timmipetit timmipetit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ugoku @nederdirk @timmipetit