Merge pull request #39 from Recras/migration-table-creation

Don't try to automagically create migration table all the time
Recras · Nov 30, 2020 · c14c57b · c14c57b
2 parents bc73264 + e3683a6
commit c14c57b
Showing 1 changed file with 1 addition and 31 deletions.
diff --git a/lib/Doctrine/Migration.php b/lib/Doctrine/Migration.php
@@ -234,8 +234,6 @@ public function setCurrentVersion($number)
      */
     public function getCurrentVersion()
     {
-        $this->_createMigrationTable();
-
         $result = $this->_connection->fetchColumn("SELECT version FROM " . $this->_migrationTableName);
 
         return isset($result[0]) ? $result[0]:0;
@@ -248,8 +246,6 @@ public function getCurrentVersion()
      */
     public function hasMigrated()
     {
-        $this->_createMigrationTable();
-
         $result = $this->_connection->fetchColumn("SELECT version FROM " . $this->_migrationTableName);
 
         return isset($result[0]) ? true:false;
@@ -309,8 +305,6 @@ public function migrate($to = null, $dryRun = false)
     {
         $this->clearErrors();
 
-        $this->_createMigrationTable();
-
         $this->_connection->beginTransaction();
 
         try {
@@ -526,28 +520,4 @@ protected function _doMigrateStep($direction, $num)
             $this->addError($e);
         }
     }
-
-    /**
-     * Create the migration table and return true. If it already exists it will
-     * silence the exception and return false
-     *
-     * @return boolean $created Whether or not the table was created. Exceptions
-     *                          are silenced when table already exists
-     */
-    protected function _createMigrationTable()
-    {
-        if ($this->_migrationTableCreated) {
-            return true;
-        }
-
-        $this->_migrationTableCreated = true;
-
-        try {
-            $this->_connection->export->createTable($this->_migrationTableName, array('version' => array('type' => 'integer', 'size' => 11)));
-
-            return true;
-        } catch(Exception $e) {
-            return false;
-        }
-    }
-}
+}