Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcwBridges recipe fixes #952

Draft
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

DoktorMephistopheles
Copy link
Contributor

fixes swapped recipes and stone bridge using wooden slabs

fixes swapped recipes and stone bridge using wooden slabs
@democat3457
Copy link
Member

is genericStoneSlabs an actual oredict, because i can't find it anywhere in the codebase

@DoktorMephistopheles
Copy link
Contributor Author

I do not think there is an oredict for generic stone slabs, however this pseudo-oredict works just doesnt include all brick slabs.

@democat3457
Copy link
Member

how does the pseudo-oredict work if the oredict doesn't exist

@DoktorMephistopheles
Copy link
Contributor Author

some sort of magic probably. i loaded the game and the recipe changed and shows coade stone brick slabs

@democat3457
Copy link
Member

I would recommend adding the remaining brick slabs to the oredict though, and preferably in one named non-generic - like <ore:stoneSlab>. You can add items to the oredict by doing something like the following inside minecraft.zs:

val stoneSlabs = <ore:stoneSlab>;
stoneSlabs.add(<item1>);
stoneSlabs.add(<item2>);
...

This will automatically create the stoneSlab oredict if it does not already exist.

@democat3457 democat3457 marked this pull request as draft July 22, 2022 00:25
@DoktorMephistopheles
Copy link
Contributor Author

I texted elite about assisting me with this today. just got home so i will look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants