Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on VERSION_STATUS environmental variable #114

Merged

Conversation

madmiraal
Copy link
Contributor

Currently, there is support for overriding the version status using an environmental variable. However, this unnecessarily obfuscates the status of a Rebel version.

This PR removes the ability to override the version status and a build's dependence of the external variable used.

@madmiraal madmiraal added the PR Type: Enhancement Your current game will work better. label Jan 19, 2025
@DanielaOrtner DanielaOrtner self-requested a review January 22, 2025 11:49
Copy link
Contributor

@DanielaOrtner DanielaOrtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DanielaOrtner DanielaOrtner merged commit f74db15 into RebelToolbox:main Jan 22, 2025
15 checks passed
@madmiraal madmiraal deleted the remove-external-variable-dependence branch January 22, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Type: Enhancement Your current game will work better.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants