Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Typescript #119

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from
Draft

Migrate to Typescript #119

wants to merge 37 commits into from

Conversation

EdJoPaTo
Copy link
Collaborator

This is not yet "nice". A bunch of stuff is just any, a lot of lint rules are disabled, … This is nowhere near a "finished" PR, its definitely a draft. Just wanted to show there is something to continue with if someone else is interested here too.

If you are reading this: Feel free to be annoying about some things. There is a lot potential for improvements. Go ahead and improve it ;)

@coveralls
Copy link

coveralls commented Feb 19, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-8.06%) to 91.935% when pulling d09e971 on EdJoPaTo:typescript into a1b094d on RealSpeaker:master.

@TemaSM TemaSM added this to the v2.х (TypeScript) milestone Feb 19, 2021
@dependabot-preview
Update eslint-plugin-promise requirement from ^4.2.1 to ^4.3.1 (RealS…
b53f1a2 
…peaker#115)

Updates the requirements on [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) to permit the latest version.
- [Release notes](https://github.com/xjamundx/eslint-plugin-promise/releases)
- [Changelog](https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md)
- [Commits](eslint-community/eslint-plugin-promise@v4.2.1...v4.3.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update eslint requirement from ^7.19.0 to ^7.21.0 (RealSpeaker#123)
aee25cd 
Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.19.0...v7.21.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update mocha requirement from ^8.2.1 to ^8.3.1 (RealSpeaker#124)
f989d17 
Updates the requirements on [mocha](https://github.com/mochajs/mocha) to permit the latest version.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v8.2.1...v8.3.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update eslint-plugin-mocha requirement from ^8.0.0 to ^8.1.0 (RealSpe…
5e0aa3b 
…aker#122)

Updates the requirements on [eslint-plugin-mocha](https://github.com/lo1tuma/eslint-plugin-mocha) to permit the latest version.
- [Release notes](https://github.com/lo1tuma/eslint-plugin-mocha/releases)
- [Changelog](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md)
- [Commits](lo1tuma/eslint-plugin-mocha@8.0.0...8.1.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update telegraf requirement from ^4.0.2 to ^4.2.1 (RealSpeaker#125)
d722669 
Updates the requirements on [telegraf](https://github.com/telegraf/telegraf) to permit the latest version.
- [Release notes](https://github.com/telegraf/telegraf/releases)
- [Commits](telegraf/telegraf@v4.0.2...v4.2.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Create Dependabot config file (RealSpeaker#130)
96024f7 
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update eslint requirement from ^7.21.0 to ^7.24.0 (RealSpeaker#131)
8e04906 
Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.21.0...v7.24.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update mocha requirement from ^8.3.1 to ^8.3.2 (RealSpeaker#126)
71af196 
Updates the requirements on [mocha](https://github.com/mochajs/mocha) to permit the latest version.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v8.3.1...v8.3.2)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@dependabot-preview
Update telegraf requirement from ^4.2.1 to ^4.3.0 (RealSpeaker#127)
19976d9 
Updates the requirements on [telegraf](https://github.com/telegraf/telegraf) to permit the latest version.
- [Release notes](https://github.com/telegraf/telegraf/releases)
- [Commits](telegraf/telegraf@v4.2.1...v4.3.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@EdJoPaTo EdJoPaTo mentioned this pull request May 21, 2021
Closed
@EdJoPaTo EdJoPaTo mentioned this pull request Jun 1, 2021
Open
dependabot bot added 7 commits June 5, 2021 17:01
@dependabot
Update mocha requirement from ^8.3.2 to ^8.4.0 (RealSpeaker#134)
898627c 
Updates the requirements on [mocha](https://github.com/mochajs/mocha) to permit the latest version.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v8.3.2...v8.4.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Update jsdoc requirement from ^3.6.6 to ^3.6.7 (RealSpeaker#138)
2ba790a 
Updates the requirements on [jsdoc](https://github.com/jsdoc/jsdoc) to permit the latest version.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/3.6.7/CHANGES.md)
- [Commits](jsdoc/jsdoc@3.6.6...3.6.7)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Update eslint requirement from ^7.24.0 to ^7.28.0 (RealSpeaker#149)
6616e05 
Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.24.0...v7.28.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump eslint-plugin-mocha from 8.2.0 to 9.0.0 (RealSpeaker#143)
58d7344 
Bumps [eslint-plugin-mocha](https://github.com/lo1tuma/eslint-plugin-mocha) from 8.2.0 to 9.0.0.
- [Release notes](https://github.com/lo1tuma/eslint-plugin-mocha/releases)
- [Changelog](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md)
- [Commits](lo1tuma/eslint-plugin-mocha@8.2.0...9.0.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Update eslint-config-standard requirement from ^16.0.2 to ^16.0.3 (Re…
74f8494 
…alSpeaker#141)

Updates the requirements on [eslint-config-standard](https://github.com/standard/eslint-config-standard) to permit the latest version.
- [Release notes](https://github.com/standard/eslint-config-standard/releases)
- [Changelog](https://github.com/standard/eslint-config-standard/blob/master/CHANGELOG.md)
- [Commits](standard/eslint-config-standard@v16.0.2...v16.0.3)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump eslint-plugin-promise from 4.3.1 to 5.1.0 (RealSpeaker#146)
7343db5 
Bumps [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise) from 4.3.1 to 5.1.0.
- [Release notes](https://github.com/xjamundx/eslint-plugin-promise/releases)
- [Changelog](https://github.com/xjamundx/eslint-plugin-promise/blob/development/CHANGELOG.md)
- [Commits](https://github.com/xjamundx/eslint-plugin-promise/commits)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Update eslint-plugin-import requirement from ^2.22.1 to ^2.23.4 (Real…
ca0adf0 
…Speaker#148)

Updates the requirements on [eslint-plugin-import](https://github.com/benmosher/eslint-plugin-import) to permit the latest version.
- [Release notes](https://github.com/benmosher/eslint-plugin-import/releases)
- [Changelog](https://github.com/benmosher/eslint-plugin-import/blob/master/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.22.1...v2.23.4)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
TemaSM and others added 4 commits June 7, 2021 16:29
@TemaSM
👷 Enable GitHub Actions as CI for tests & coverage reports
5a6e0a8 
* remove Travis CI
@TemaSM
📝 Better readme and extra.js example fix
a921e15
@dependabot
Bump mocha from 8.4.0 to 9.0.1 (RealSpeaker#151)
1f5c1d0 
Bumps [mocha](https://github.com/mochajs/mocha) from 8.4.0 to 9.0.1.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v8.4.0...v9.0.1)

---
updated-dependencies:
- dependency-name: mocha
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Update eslint requirement from ^7.28.0 to ^7.29.0 (RealSpeaker#154)
0f5bf4d 
Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.28.0...v7.29.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 19, 2021

This pull request introduces 1 alert when merging 680ca7a into a1b094d - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 19, 2021

This pull request introduces 1 alert when merging 245c9d4 into a1b094d - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@EdJoPaTo
Copy link
Collaborator Author

EdJoPaTo commented Jul 19, 2021 •
edited
Loading

I went in a more radical approach with this. Mainly I implemented the async File lowdb variant manually and removed the dependency of lowdb and lodash-id completely.
As a downside the configurable storage is gone but its way simpler code with useful typings (lodash-id never had typescript typings).
It always uses async logic now and it works with grammY out of the box now.

Open questions:

  • The docs are gone currently… how to deal with that?
  • Readme only praised features that got removed…
  • 2 Testfiles are containing tests that aren't that specific to their filename. Maybe give them a better structure?
  • fs/promises does not seem to work with Node.js 12. Why? Find out why or maybe just drop Node.js 12 support? Its a breaking change release anyway.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 31, 2021

This pull request introduces 1 alert when merging 1913594 into a1b094d - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jul 31, 2021

This pull request introduces 1 alert when merging d09e971 into a1b094d - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@gabrieljaegerde
Copy link

whats the status on this?

@gabrieljaegerde
Copy link

whats the status on this?

@EdJoPaTo are you still working on this? Or is this project looking for some new active community members to fix this repo up?

@EdJoPaTo
Copy link
Collaborator Author

whats the status on this?

@EdJoPaTo are you still working on this? Or is this project looking for some new active community members to fix this repo up?

Check my last message, this PR changed a lot of the internals and no one really commented on that so far (besides bots).

@TemaSM TemaSM modified the milestones: v2.х (TypeScript), v3.x Jan 9, 2023
@TemaSM TemaSM force-pushed the master branch 3 times, most recently from 55b4ac1 to ffdd632 Compare January 11, 2023 03:19
@TemaSM TemaSM force-pushed the master branch 3 times, most recently from da156d6 to 11fb25c Compare January 29, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: High Severity: Major Status: In progress Type: Enhancement
Projects
None yet
Milestone
v3.x
Development

Successfully merging this pull request may close these issues.
4 participants
@EdJoPaTo @coveralls @gabrieljaegerde @TemaSM