-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Add module-info.java #7332
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.x #7332 +/- ##
============================================
- Coverage 99.55% 99.51% -0.05%
+ Complexity 6781 6778 -3
============================================
Files 751 751
Lines 47482 47482
Branches 6378 6378
============================================
- Hits 47271 47252 -19
- Misses 96 103 +7
- Partials 115 127 +12
Continue to review full report at Codecov.
|
I suggest #7333. |
Thanks for the contribution. After exploring the options, I prefer #7241 because it doesn't confuse IDEs and requires only minimal changes to the build. |
That's strange, I did this in IntelliJ and it worked fine |
This uses basic Gradle APIs to configure an MR-Jar with a
module-info.java
file. Resolves #7240, continuation from #7241 but without the need for an extra plugin and works around thebnd
issue (they lack support for this and seeing as the issue is 4 years old it's not clear that they ever will).This uses Gradle toolchains for simpler control over compilations, allowing us to target Java 8 for the
main
java sources and use Java 11 (but targeting java 9) for themodule-info.java
file, then adding the compiledmodule-info.class
to the final jar under the appropriateMETA-INF/versions/9
path.