Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gas grenade particles disappearing #659

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

jhh8
Copy link
Member

@jhh8 jhh8 commented Oct 31, 2023

make gas grenade particles fully client side, just like firemine and env_fire particles

make gas grenade particles fully client side, just like firemine and env_fire particles
@jhh8
Copy link
Member Author

jhh8 commented Oct 31, 2023

there's one small problem i realised, if a player joins the server while the gas has been up for lets say 20 seconds, then it will show the particles to that person for 30 seconds instead of the 10 seconds that are left, i assume? the solution could be to have a float netprop which tells at which time the grenade has detonated, then do StopEmission

@BenLubar
Copy link
Contributor

This will break if someone throws a gas grenade after a level has been running for ~12 days but I think that's fine.

@BenLubar BenLubar merged commit 34d73b3 into reactivedrop_beta Oct 31, 2023
2 checks passed
@BenLubar BenLubar deleted the gasgrenade-particles-fix branch October 31, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants