-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added auto-completion for RMG thermo and kinetics libraries based on the chemistry set #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeenFahoum
requested changes
Oct 31, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 47.30% 47.54% +0.23%
==========================================
Files 25 25
Lines 3420 3458 +38
Branches 922 934 +12
==========================================
+ Hits 1618 1644 +26
- Misses 1597 1606 +9
- Partials 205 208 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alongd
force-pushed
the
rec_libs
branch
3 times, most recently
from
October 31, 2024 11:28
9cc8845
to
b250429
Compare
Added a validator and made libraries optional
LeenFahoum
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RMG's libraries are an important asset, yet it takes an expert to know which library to use per application.
This contribution added a feature that allows users to request auto-completion for their libraries by just describing the application of their chemistry set: [
'primary', 'nitrogen', 'sulfur', 'combustion', 'CH_pyrolysis']
The recommended libraries will be appended in addition to any user-supplied libraries (not adding duplicates)
Tests were added