Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Cache and Docker CI #142

Merged
merged 7 commits into from
Nov 12, 2023
Merged

Fixing Cache and Docker CI #142

merged 7 commits into from
Nov 12, 2023

Conversation

calvinp0
Copy link
Member

@calvinp0 calvinp0 commented Nov 9, 2023

The Docker CI is running out of space, thus adding a removal run of unneccesaryfiles. The Cache CI fails with RMS installation via Julia. Reworked the installation code.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Merging #142 (da97d4e) into main (2de3b76) will increase coverage by 1.69%.
Report is 74 commits behind head on main.
The diff coverage is 83.77%.

@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   73.46%   75.15%   +1.69%     
==========================================
  Files          22       24       +2     
  Lines        2891     3293     +402     
  Branches      762      842      +80     
==========================================
+ Hits         2124     2475     +351     
- Misses        552      593      +41     
- Partials      215      225      +10     
Flag Coverage Δ
unittests 75.15% <83.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
t3/common.py 89.77% <100.00%> (+5.86%) ⬆️
t3/logger.py 60.00% <ø> (-1.09%) ⬇️
t3/settings/t3_settings.py 100.00% <ø> (ø)
t3/settings/t3_submit.py 100.00% <ø> (ø)
t3/runners/rmg_runner.py 34.37% <0.00%> (ø)
t3/imports.py 30.00% <40.00%> (ø)
t3/simulate/rmg_constantTP.py 58.41% <0.00%> (ø)
t3/utils/fix_cantera.py 90.66% <90.66%> (ø)
t3/utils/flux.py 84.35% <84.35%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @calvinp0 for investing in a quality CI for T3. Much appreciated.

@alongd alongd merged commit 6d1b6d6 into main Nov 12, 2023
4 checks passed
@alongd alongd deleted the cache_docker_ci branch November 12, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants