Radical solvation thermo groups #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These groups are radical corrections to the H bonding 'A' value. We use them after we calculate solvation thermo for a saturated structure that we made by saturating radicals with hydrogens.
Radical groups were added for all Platts groups that have an A value, if they'd come about by saturating with H.
For some reason, there was no data for this group despite there being a Platts group. Allows ammonia unit test to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These values correct the Abraham 'A' values for radicals that had been saturated with H's when looking up the solvation. Goes along with pull request ReactionMechanismGenerator/RMG-Py#364 in RMG-Py