Fix group definitions in Intra_R_Add_Endocyclic #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See ReactionMechanismGenerator/RMG-Py#69 for detailed workup. R5_DS_allenic now has consistent atom types and bonds, i.e. *2 is always a Cdd with 2 double bonds. *3 cannot be a Ct nor have a triple bond. multiplebond_intra also now allows *2 to be Cdd
Third body reactions are all in their low pressure limit when they depend on the collider concentration. This change was made in RMG-Py in ReactionMechanismGenerator/RMG-Py@2ea6522 See issue ReactionMechanismGenerator#7
Replace arrhenius coefficient unit 'cm^3/(mol*s)' with 'cm^6/(mol*s)' and 's^-1' with 'cm^3/(mol*s)' in ThirdBody reactions See issue ReactionMechanismGenerator#7
This describes something else, and shouldn't be here. There are probably other examples of this type of thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ReactionMechanismGenerator/RMG-Py#69 for detailed workup.
R5_DS_allenic now has consistent atom types and bonds, i.e. *2 is always a Cdd
with 2 double bonds. *3 cannot be a Ct nor have a triple bond.
multiplebond_intra also now allows *2 to be Cdd
This seems to close that bug