Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the ethylamine H abstraction reactions by H/CH3/NH2 #217

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

alongd
Copy link
Member

@alongd alongd commented Sep 28, 2017

Updated H abstraction rates in the ethylamine library as well as respective training reactions
(rates taken from doi: 10.1016/j.combustflame.2015.10.032)
These rates are calculated in g09 at CBS-QB3 with fancy tunneling.
Compared to experimental values they gave better results for ethylamine pyrolysis and oxidation than our previous in-house CBS-QB3 rates.

@alongd
Copy link
Member Author

alongd commented Oct 11, 2017

@nyee , this PR is now clean and ready for review.

@@ -7,10 +7,16 @@
Automated Reaction Mechanism Generation Including Heteroatoms: Nitrogen
Alon Grinberg Dana, Beat Buesser, Shamel S. Merchant, William H. Green
Table 2
Kinetic data for reactions 1-9, 13-24 were calculated using:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are trying to move to a machine writable database, which may cause some indexes to change. Keeping the source described by the index, may lead to some problems if the indexes were modified (though @nyee would know more about this).

Is there a way to add a description to each kinetic entry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting catch, will do.

@@ -7,10 +7,16 @@
Automated Reaction Mechanism Generation Including Heteroatoms: Nitrogen
Alon Grinberg Dana, Beat Buesser, Shamel S. Merchant, William H. Green
Table 2
Kinetic data for reactions 1-9, 13-24 were calculated using:
Kinetic data for reactions 13-27 were calculated using:
CBS-QB3 for energy barriers, B3LYP/6-311G(2d,d,p) for partition functions, hybrid meta-GGA BMK/6-311G(2d,d,p) for addition reactions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful for people to know who did these calculations (so they can look it up on pharos or something).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Ea = (6800, 'cal/mol'),
A = (1.6e+13, 'cm^3/(mol*s)'),
n = 0,
Ea = (8174, 'cal/mol'),
T0 = (1, 'K'),
Tmin = (700, 'K'),
Tmax = (2000, 'K'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to list the source (journal doi) in the long description for these entries? Just in case the library and training reactions get separated (or the library indexes change), it may be good to have the source directly from the training reaction.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@alongd alongd removed the request for review from nyee October 13, 2017 20:51
@alongd
Copy link
Member Author

alongd commented Oct 13, 2017

@goldmanm, thanks for the comments, they were all addressed. Let me know if there are any other concerns regarding this PR.

Updated H abstraction rates in the library as well as H Abstraction
training reactions
(rates taken from doi: 10.1016/j.combustflame.2015.10.032)
Copy link
Contributor

@goldmanm goldmanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thanks for this awesome PR.

@goldmanm
Copy link
Contributor

@nyee, would you be able to merge this?

@mliu49 mliu49 merged commit 7420f10 into master Oct 18, 2017
@mliu49 mliu49 deleted the ethylamine branch October 18, 2017 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants