Forbid a charged carbene in singlet_carbene_intra_disproportionation #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongd
force-pushed
the
chargedCarbene
branch
from
f7aa4c9 to
731283b
Compare
…nation Forbidding a charged carbene such as in C[C-]=[N+]=O from reacting in the singlet_carbene_intra_disproportionation family. See #213.
alongd
force-pushed
the
chargedCarbene
branch
from
731283b to
056ca9c
Compare
|
@nyee, thanks for your comment in #213. |
|
@zjburas , I re-ran Travis, and this PR is now clean. Could you take a look? |
zjburas
approved these changes
Oct 13, 2017
|
Yes, it does the trick and solves #213 as well. |
|
Great, then I think someone with the authority can merge this. |
|
@nyee, I still can't merge PRs on the database repo... strange. |
|
@alongd, I modified the permissions. You should be able to merge now. |
|
Thanks @mliu49 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #213 by adding the simple forbidden group
to
carbene in singlet_carbene_intra_disproportionation.@zjburas and I were thinking what would be the best approach (adding
c0to all node? leaving the forbidden group?) @nyee would you have any suggestions?