Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the rates should be expressed in MultiArrhenius form within FFCM mechanism #187

Merged
merged 2 commits into from
May 10, 2017

Conversation

jimchu10
Copy link
Contributor

@jimchu10 jimchu10 commented May 3, 2017

There are rates of total 7 reactions in FFCM should be shown in MultiArrhenius form, but the previous version has only one with that form.
The rest 6 only has single Arrhenius form corresponding to the first Arrhenius in FFCM.
Now they are corrected and should be able to capture both high and low temperature.

jimchu10 added 2 commits May 3, 2017 17:54
…FCM mechanism

There are rates of total 7 reactions in FFCM should be shown in FFCM form, but the previous version has only one with that form.
The rest 6 only has single Arrhenius form corresponding to the first Arrhenius in FFCM.
Now they are corrected and should be able to capture both high and low temperature.
Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimchu10
@nyee, I reviewed this, but don't have merging permission on database.
Could you merge?

),
Arrhenius(
A = (5.017e+12, 'cm^3/(mol*s)'),
n = 0.664,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimchu10 , I think n should be -0.664 here.
Could you check and correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I made the change in the updated pull request

@nyee nyee merged commit 958c114 into master May 10, 2017
@nyee nyee deleted the fix_FFCM_MultiArrhenius branch May 10, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants