Skip to content

Commit

Permalink
Allow cat of regression diff to fail
Browse files Browse the repository at this point in the history
This matches a corresponding change in the CI
workflow file for RMG-Py, which was introduced
to account for very large differences between
the dynamic and baseline test results.

See: ReactionMechanismGenerator/RMG-Py#2316 (comment)
  • Loading branch information
ssun30 committed Nov 24, 2024
1 parent 1c25ad1 commit 2c02748
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ jobs:
export FAILED=Yes
fi
echo "" # blank line so next block is interpreted as markdown
cat "$regr_test-core.log"
cat "$regr_test-core.log" || (echo "Dumping the whole log failed, please download it from GitHub actions. Here are the first 100 lines:" && head -n100 "$regr_test-core.log")
echo "</details>"
echo "<details>"
if python-jl scripts/checkModels.py \
Expand All @@ -225,7 +225,7 @@ jobs:
export FAILED=Yes
fi
echo "" # blank line so next block is interpreted as markdown
cat "$regr_test-edge.log"
cat "$regr_test-edge.log" || (echo "Dumping the whole log failed, please download it from GitHub actions. Here are the first 100 lines:" && head -n100 "$regr_test-core.log")
echo "</details>"
# Check for Regression between Reference and Dynamic (skip superminimal)
Expand Down

0 comments on commit 2c02748

Please sign in to comment.