Flux diagram for chosen species #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 13, 2012 10:00
Flux diagrams can now be created that focus on a chosen species. This is done by adding optional parameter centralSpecies to -generateFluxDiagram -createFluxDiagram The parameter contains the name of the species mentioned in the chemkin file. If the parameter is passed to the method, then: -the index of this particular species in speciesList is sought -the "nodes" object is populated with the other reactants / products in which the central species is mentioned -creation of the edges object remains the same The rest remains the same.
…Species Also, added declaration of global variables in methods for the global variables like maximumNodeCount to avoid interpreting them as local variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the risk of self-promotion, i hereby recommend you this branch:
Instead of creating a global flux diagram with all the important species, this branch gives the option to create a flux diagram centralized around a user chosen species. What it does is:
Solved merge conflicts due to recently changed method signature updates (Connie's settings parameter)
added a line declaring globally used variables to avoid interpretation as local variables when settings object is not set.
Tested successfully with and without setting a chosen species, but no unit test added...