-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tree averaging issue #712 #713
Conversation
No time to look into it further myself now, but I think this is being killed because it's run out of memory on travis, not because it's run out of time. |
37ea75c
to
79966f6
Compare
In addition to kehang's notes on this pull request, I have also updated:
C2H3(13) + C2H3(13) ⇔ C2H4(8) + C#C(25) Before:
After:
Although this pull request increases the time required to run the minimal example, we believe that the kinetics estimation is in fact better than it was previously. Running the |
…mplate As agreed upon by Prof. Green, we will no longer average strict children, instead we will average together manhattan distance 1 nodes and traverse the tree completely before stopping
…t when there's just one entry Deep copy the kinetics even if one entry is used in the average, because we are going to be modifying the comments and we don't want to modify the original object. Use just the children's template labels for an averaged rule's comments. This modifies the commenting that we used to do, which traces the entire averaging history by recursively appending to the kinetics comments in order to view the actual original templates that factor into the average. Instead this new method of writing the kinetics comments just lists the distance 1 children that in fact has kinetics. In order to do more detailed analysis, one would have to go inside to uncomment the debug lines that use the former kinetics comment style that retains full information. However, this is too memory intensive and difficult to read for normal RMG jobs, and wil print out too much to verbose chemkin output using the original method.
Previously, we were using a distance algorithm that choose the manhattan distance. Now we move to use the Euclidian norm distance instead in hopes of decreasing the usage of very general nodes Speed up norm distance calculation by storing the node's level in the Entry() object when parsing group tree
79966f6
to
b21bc48
Compare
This PR tries to fix the issue #712 by