Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draw Radicals on Groups #2715

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Draw Radicals on Groups #2715

wants to merge 1 commit into from

Conversation

mjohnson541
Copy link
Contributor

Right now you can't visually tell where radicals are on drawn groups structures, this draws the radical on GroupAtoms where the attribute radical_electrons == [1].

@rwest rwest force-pushed the draw_radical_on_groups branch from b9ddea0 to d450941 Compare November 20, 2024 18:12
Copy link
Member

@rwest rwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rwest rwest enabled auto-merge (rebase) November 20, 2024 18:47
@rwest
Copy link
Member

rwest commented Nov 21, 2024

Looks like test/rmgpy/molecule/groupTest.py::TestGroup::test_draw_group needs updating.

Draw radical on Groups
@rwest rwest force-pushed the draw_radical_on_groups branch from d450941 to fd92d07 Compare December 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants