-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbage Commit to Trigger CI (see #2663) #2667
Conversation
This one fails after >199 min (one of them at 212, but maybe it's a glitch of the 200 min rule) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2667 +/- ##
=======================================
Coverage 54.79% 54.79%
=======================================
Files 125 125
Lines 37156 37156
=======================================
Hits 20361 20361
Misses 16795 16795 ☔ View full report in Codecov by Sentry. |
Looks like you're making progress! If you need to commit to main to get the reference artifact uploaded, feel free IMHO. |
@rwest thanks for the note, have done that here. Interestingly, changing As a fix now I have set the runner to macos-13, which runs on intel. In the future will would need conda binaries on our channel that are built for apple hardware. Rather than merge this PR I will just get it to fail the way I want it to (it should discover the correct run of the CI), and then I will move these changes to a branch on my fork, open a new PR, and merge that if it 'fails right'. Just want to make sure this works from forks. |
Great. Yes, let's aim for Intel Mac and Mac Silicon binaries for all conda dependencies - maybe this summer? (Not this PR) |
Yes for sure. #2641 would be a big part of that, since it should allow us to rebuild the RMG binaries for the first time in a while. |
- increment miniconda setup to v3 from v2 - set macos build runner to use intel macs rather than m1, since we don't have binaries for m1 - switch download artifact step to use the official github one, which now allows grabbing artifacts from other runs Resolves ReactionMechanismGenerator#2611 See ReactionMechanismGenerator#2667 for more history
Closing in favor of #2669 |
- increment miniconda setup to v3 from v2 - set macos build runner to use intel macs rather than m1, since we don't have binaries for m1 - switch download artifact step to use the official github one, which now allows grabbing artifacts from other runs Resolves ReactionMechanismGenerator#2611 See ReactionMechanismGenerator#2667 for more history asdf
I have started this here: ReactionMechanismGenerator/conda-recipes#18 |
Title