Use autoGenerated tag instead of the hardcoded family list #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwest
reviewed
Jun 14, 2021
hwpang
force-pushed
the
fix_databaseTestforTreeGen
branch
from
8ca9754 to
3fc42a1
Compare
|
@rwest Thanks for the catch! |
rwest
previously approved these changes
Jun 14, 2021
ChrisBNEU
previously approved these changes
Jun 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #2157 +/- ##
==========================================
+ Coverage 47.91% 48.26% +0.34%
==========================================
Files 101 101
Lines 26989 27210 +221
Branches 6911 7125 +214
==========================================
+ Hits 12932 13133 +201
+ Misses 12684 12680 -4
- Partials 1373 1397 +24
Continue to review full report at Codecov.
|
|
Can you rebase? |
hwpang
force-pushed
the
fix_databaseTestforTreeGen
branch
from
3fc42a1 to
bf8afcd
Compare
Rebased! |
mjohnson541
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation or Problem
Multiple PRs in RMG-database related to tree generation failed the database test (e.g. ReactionMechanismGenerator/RMG-database#493 and ReactionMechanismGenerator/RMG-database#495)
Description of Changes
Made the code to look for auto_generated tag instead of the hardcoded list to avoid needing to twin PR
Testing
I didn't run a test as this should be a straight forward change