Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse recipes should be in reverse order #1829

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Reverse recipes should be in reverse order #1829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rmgpy/data/kinetics/family.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def get_reverse(self):
of the reaction that this is the recipe for.
"""
other = ReactionRecipe()
for action in self.actions:
for action in reversed(self.actions): # Play the reverse recipe in the reverse order
if action[0] == 'CHANGE_BOND':
other.add_action(['CHANGE_BOND', action[1], str(-int(action[2])), action[3]])
elif action[0] == 'FORM_BOND':
Expand Down