Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
- clearer error messages

Co-authored-by: Hao-Wei Pang <[email protected]>
  • Loading branch information
JacksonBurns and hwpang authored Jun 12, 2024
1 parent 24a0731 commit dcef9ab
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions rmgpy/pdep/sls.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
from diffeqpy import de
from julia import Main
except Exception as e:
warnings.warn(
logging.info(
f"Unable to import Julia dependencies, original error: {str(e)}"
". Master equation method 'ode' will not be available on this execution."
)
Expand Down Expand Up @@ -163,7 +163,7 @@ def get_rate_coefficients_SLS(network, T, P, method="mexp", neglect_high_energy_
if NO_JULIA:
raise RuntimeError(
"Required Julia dependencies for method 'ode' are not installed.\n"
"Please check your installation (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/index.html)."
"Please follow the steps to install Julia dependencies at https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/anacondaDeveloper.html."
)
f = Main.eval(
"""
Expand Down
2 changes: 1 addition & 1 deletion rmgpy/rmg/input.py
Original file line number Diff line number Diff line change
Expand Up @@ -1562,7 +1562,7 @@ def read_input_file(path, rmg0):
if NO_JULIA:
logging.error(
"During runtime, import of Julia dependencies failed. To use phase systems and RMS reactors, install RMG-Py with RMS."
" (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/index.html)"
" (https://reactionmechanismgenerator.github.io/RMG-Py/users/rmg/installation/anacondaDeveloper.html)"
)
logging.exception(e)
raise
Expand Down

0 comments on commit dcef9ab

Please sign in to comment.